change Steam_Apps::SetDlcContext() according to review notes by universal963

This commit is contained in:
otavepto 2024-07-06 01:41:50 +03:00
parent 61d519bf0e
commit fd0126ee25
2 changed files with 4 additions and 2 deletions

View File

@ -471,7 +471,10 @@ bool Steam_Apps::SetDlcContext( AppId_t nAppID )
PRINT_DEBUG("%u // TODO", nAppID); PRINT_DEBUG("%u // TODO", nAppID);
std::lock_guard<std::recursive_mutex> lock(global_mutex); std::lock_guard<std::recursive_mutex> lock(global_mutex);
if (nAppID == 0) return false; // TODO is this correct? (see Steam_Apps::BIsDlcInstalled) // TODO this one is very odd, in all other functions of this interface they were returning false
// tested by `universal963` on real steam
if (nAppID == 0) return true;
if (nAppID == UINT32_MAX) return false; // TODO is this correct? (see Steam_Apps::BIsDlcInstalled) if (nAppID == UINT32_MAX) return false; // TODO is this correct? (see Steam_Apps::BIsDlcInstalled)
if (nAppID == settings->get_local_game_id().AppID()) return true; // TODO is this correct? if (nAppID == settings->get_local_game_id().AppID()) return true; // TODO is this correct?

View File

@ -1,6 +1,5 @@
#pragma once #pragma once
#include <string>
#include <string> #include <string>
#include <string_view> #include <string_view>
#include <mutex> #include <mutex>