From 34260498335e6df66aa23457c9a3419b689a8c41 Mon Sep 17 00:00:00 2001
From: otavepto <153766569+otavepto@users.noreply.github.com>
Date: Mon, 25 Dec 2023 15:22:02 +0200
Subject: [PATCH] update workflow scripts to just fail as early as possible

---
 .github/workflows/build-linux.yml | 8 +-------
 .github/workflows/build-win.yml   | 8 +-------
 2 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml
index d88d111c..486eda11 100644
--- a/.github/workflows/build-linux.yml
+++ b/.github/workflows/build-linux.yml
@@ -80,21 +80,18 @@ jobs:
 
 ### build (release mode)
     - name: Build release mode
-      continue-on-error: true
       shell: bash
       working-directory: ${{ github.workspace }}
       run:  "sudo chmod 777 build_linux.sh && ./build_linux.sh release"
 
 ### package (release mode)
     - name: Package build (release)
-      if: success()
       shell: bash
       working-directory: ${{ github.workspace }}
       run: sudo chmod 77 package_linux.sh && sudo ./package_linux.sh release
 
 ### upload artifact/package to github Actions (release mode)
     - name: Upload build pacakge (release)
-      if: success()
       uses: actions/upload-artifact@v4
       with:
         name: "build-linux-release-${{ github.sha }}"
@@ -105,21 +102,18 @@ jobs:
     
 ### build (debug mode)
     - name: Build debug mode
-      continue-on-error: true
       shell: bash
       working-directory: ${{ github.workspace }}
       run:  "sudo chmod 777 build_linux.sh && ./build_linux.sh debug"
 
 ### package (debug mode)
     - name: Package build (debug)
-      if: success()
       shell: bash
       working-directory: ${{ github.workspace }}
       run: sudo chmod 77 package_linux.sh && sudo ./package_linux.sh debug
 
 ### upload artifact/package to github Actions (debug mode)
     - name: Upload build pacakge (debug)
-      if: success()
       uses: actions/upload-artifact@v4
       with:
         name: "build-linux-debug-${{ github.sha }}"
@@ -130,7 +124,7 @@ jobs:
     
 ### release (debug + release modes) if this is a tag push
     - name: Release
-      if: success() && startsWith(github.ref, 'refs/tags/')
+      if: startsWith(github.ref, 'refs/tags/')
       uses: softprops/action-gh-release@v1
       with:
         files: "${{ env.PACKAGE_ROOT_PATH }}/**/*"
diff --git a/.github/workflows/build-win.yml b/.github/workflows/build-win.yml
index 3505aed0..54c4a361 100644
--- a/.github/workflows/build-win.yml
+++ b/.github/workflows/build-win.yml
@@ -86,21 +86,18 @@ jobs:
 
 ### build (release mode)
     - name: Build release mode
-      continue-on-error: true
       shell: cmd
       working-directory: ${{ github.workspace }}
       run: build_win.bat release
 
 ### package (release mode)
     - name: Package build (release)
-      if: success()
       shell: cmd
       working-directory: ${{ github.workspace }}
       run: package_win.bat release
 
 ### upload artifact/package to github Actions (release mode)
     - name: Upload build pacakge (release)
-      if: success()
       uses: actions/upload-artifact@v4
       with:
         name: "build-win-release-${{ github.sha }}"
@@ -111,21 +108,18 @@ jobs:
     
 ### build (debug mode)
     - name: Build debug mode
-      continue-on-error: true
       shell: cmd
       working-directory: ${{ github.workspace }}
       run: build_win.bat debug
 
 ### package (debug mode)
     - name: Package build (debug)
-      if: success()
       shell: cmd
       working-directory: ${{ github.workspace }}
       run: package_win.bat debug
 
 ### upload artifact/package to github Actions (debug mode)
     - name: Upload build pacakge (debug)
-      if: success()
       uses: actions/upload-artifact@v4
       with:
         name: "build-win-debug-${{ github.sha }}"
@@ -136,7 +130,7 @@ jobs:
     
 ### release (debug + release modes) if this is a tag push
     - name: Release
-      if: success() && startsWith(github.ref, 'refs/tags/')
+      if: startsWith(github.ref, 'refs/tags/')
       uses: softprops/action-gh-release@v1
       with:
         files: "${{ env.PACKAGE_ROOT_PATH }}/**/*"