From f8bb8b228570bedfdd40241aa3051d570a8dcd72 Mon Sep 17 00:00:00 2001
From: otavepto <153766569+otavepto@users.noreply.github.com>
Date: Sat, 6 Jan 2024 07:43:34 +0200
Subject: [PATCH] fixed the overlay crash when an invitation is sent (on guest
 side)

(cherry picked from commit fc4fbb33b11e03946bb158c465ce3cb8e02b3f45)
---
 overlay_experimental/steam_overlay.cpp | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/overlay_experimental/steam_overlay.cpp b/overlay_experimental/steam_overlay.cpp
index a5c1844a..a253c2f8 100644
--- a/overlay_experimental/steam_overlay.cpp
+++ b/overlay_experimental/steam_overlay.cpp
@@ -499,9 +499,13 @@ void Steam_Overlay::AddInviteNotification(std::pair<const Friend, friend_window_
         notif.type = notification_type_invite;
         notif.frd = &wnd_state;
 
-        char tmp[TRANSLATION_BUFFER_SIZE];
-        snprintf(tmp, sizeof(tmp), translationInvitedYouToJoinTheGame[current_language], wnd_state.first.name(), wnd_state.first.id());
-        notif.message = tmp;
+        {
+            char tmp[TRANSLATION_BUFFER_SIZE]{};
+            auto first_friend = wnd_state.first;
+            auto name = first_friend.name();
+            snprintf(tmp, sizeof(tmp), translationInvitedYouToJoinTheGame[current_language], name.c_str(), (int32_t)first_friend.id());
+            notif.message = tmp;
+        }
 
         notif.start_time = std::chrono::duration_cast<std::chrono::seconds>(std::chrono::system_clock::now().time_since_epoch());
         notifications.emplace_back(notif);
@@ -954,7 +958,7 @@ void Steam_Overlay::OverlayProc()
 
         bool show = true;
 
-        char tmp[TRANSLATION_BUFFER_SIZE];
+        char tmp[TRANSLATION_BUFFER_SIZE]{};
         snprintf(tmp, sizeof(tmp), translationRenderer[current_language], (_renderer == nullptr ? "Unknown" : _renderer->GetLibraryName().c_str()));
         std::string windowTitle;
         windowTitle.append(translationSteamOverlay[current_language]);