From e489c389903fc95b52a27f0cae71133911ea255d Mon Sep 17 00:00:00 2001
From: Akash Mozumdar <akashmozumdar@gmail.com>
Date: Fri, 9 Nov 2018 04:24:33 -0500
Subject: [PATCH] fix several perf issues in textthread

---
 GUI/host/textthread.cc | 24 ++++++++++++++----------
 GUI/host/textthread.h  |  4 ++--
 2 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/GUI/host/textthread.cc b/GUI/host/textthread.cc
index 038eb99..c235134 100644
--- a/GUI/host/textthread.cc
+++ b/GUI/host/textthread.cc
@@ -44,20 +44,24 @@ void TextThread::Push(const BYTE* data, int len)
 
 void TextThread::Flush()
 {
-	std::wstring sentence;
+	std::unique_lock locker(threadMutex);
+	if (buffer.empty()) return;
+	if (buffer.size() > maxBufferSize || GetTickCount() - lastPushTime > flushDelay)
 	{
-		LOCK(threadMutex);
-		if (buffer.empty()) return;
-		if (buffer.size() < maxBufferSize && GetTickCount() - lastPushTime < flushDelay) return;
-		sentence = buffer;
+		std::wstring sentence = buffer;
 		buffer.clear();
 
-		bool hasRepetition = false;
-		for (std::wsmatch results; std::regex_search(sentence, results, std::wregex(L"([^\\x00]{6,})\\1\\1")); hasRepetition = true) sentence = results[1];
-		if (hasRepetition) repeatingChars = std::unordered_set<wchar_t>(sentence.begin(), sentence.end());
-		else repeatingChars.clear();
+		locker.unlock(); // This algorithm might take a while
+		std::unordered_set<wchar_t> repeatingChars;
+		for (std::wsmatch results; std::regex_search(sentence, results, std::wregex(L"([^\\x00]{6,})\\1\\1")); sentence = results[1])
+			repeatingChars = std::unordered_set(sentence.begin(), sentence.end());
+		locker.lock();
+
+		this->repeatingChars = repeatingChars;
+
+		locker.unlock();
+		AddSentence(sentence);
 	}
-	AddSentence(sentence);
 }
 
 // EOF
diff --git a/GUI/host/textthread.h b/GUI/host/textthread.h
index e09b12f..67e18ae 100644
--- a/GUI/host/textthread.h
+++ b/GUI/host/textthread.h
@@ -14,8 +14,8 @@ public:
 
 	inline static OutputCallback Output;
 
-	inline static int flushDelay = 250; // flush every 250ms by default
-	inline static int maxBufferSize = 200;
+	inline static int flushDelay = 400; // flush every 400ms by default
+	inline static int maxBufferSize = 1000;
 	inline static int threadCounter = 0;
 
 	TextThread(ThreadParam tp, HookParam hp, std::wstring name);