fix buffer overrun

This commit is contained in:
Akash Mozumdar 2018-11-03 04:53:51 -04:00
parent a99131fa23
commit d42dcc1705

View File

@ -1,6 +1,5 @@
#include "extension.h" #include "extension.h"
#include <winhttp.h> #include <winhttp.h>
#include <Shlwapi.h>
#include <regex> #include <regex>
#include <QInputDialog> #include <QInputDialog>
#include <QTimer> #include <QTimer>
@ -83,7 +82,7 @@ std::wstring Translate(std::wstring text, std::wstring& translateFrom, std::wstr
if (!internet) internet = WinHttpOpen(L"Mozilla/5.0 Textractor", WINHTTP_ACCESS_TYPE_DEFAULT_PROXY, NULL, NULL, 0); if (!internet) internet = WinHttpOpen(L"Mozilla/5.0 Textractor", WINHTTP_ACCESS_TYPE_DEFAULT_PROXY, NULL, NULL, 0);
char buffer[10000] = {}; char buffer[10000] = {};
WideCharToMultiByte(CP_UTF8, 0, text.c_str(), -1, buffer, text.size() * 5, NULL, NULL); WideCharToMultiByte(CP_UTF8, 0, text.c_str(), -1, buffer, 10000, NULL, NULL);
text.clear(); text.clear();
for (int i = 0; buffer[i];) for (int i = 0; buffer[i];)
{ {
@ -108,7 +107,6 @@ std::wstring Translate(std::wstring text, std::wstring& translateFrom, std::wstr
char buffer[10000] = {}; char buffer[10000] = {};
WinHttpReceiveResponse(request, NULL); WinHttpReceiveResponse(request, NULL);
WinHttpReadData(request, buffer, 10000, &bytesRead); WinHttpReadData(request, buffer, 10000, &bytesRead);
puts(buffer);
wchar_t wbuffer[10000] = {}; wchar_t wbuffer[10000] = {};
MultiByteToWideChar(CP_UTF8, 0, buffer, -1, wbuffer, 10000); MultiByteToWideChar(CP_UTF8, 0, buffer, -1, wbuffer, 10000);
if (translateFrom.empty()) translateFrom = wbuffer; if (translateFrom.empty()) translateFrom = wbuffer;