Commit Graph

8 Commits

Author SHA1 Message Date
a
48a8ada43f very minor refactoring to Auth_Data 2023-12-24 14:33:40 +02:00
a
c5ce7ad44b completely refactor the serialization of AppTicket
+ catch objects by reference instead of by value in for loops: `for (DLC &dlc : DLCs)` vs `for (DLC dlc : DLCs)`

+ rely on C/C++ standard sizes instead of SDK definitions `uint16_t` vs `uint16` since the data sizes are very important

+ added more comments explaining the reasoning for any special handling

+ added comments exaplaining the layout of the data
2023-12-24 14:33:40 +02:00
a
e379220e16 completely refactor the serialization of AppTicketGC
+ avoid any magical numbers as much as possible & calculate the required size via sizeof()

+ use a macro to serialize a single field & increment the pointer at the same time

+ added some more debug statements
2023-12-24 14:33:40 +02:00
a
342d0a27b5 fixed is a sneaky instatnt memory deallocation, check this for details: viewtopic.php?p=2962649#p2962649 2023-12-24 14:33:40 +02:00
a
0e584aa09c hide these fields since they're constant for now, to make it clear for external callers that these are not meant to change 2023-12-24 14:33:40 +02:00
a
8b4914a684 use standard fixed-size types instead of SDK types since the size of the data is important, to avoid any magic compiler definitions (love C++) 2023-12-24 14:33:40 +02:00
a
e8f64faf17 add a new serialization method to DLC struct 2023-12-24 14:33:40 +02:00
Detanup01
b697c8bd2d All Auth token support 2023-12-24 14:33:40 +02:00