disable friend avatar functionality by default + new option to enable it

CHANGELOG.md

@@ -23,6 +23,7 @@
   
   in both cases, the tool will create a new folder `steam_settings` in the current directory with all the results of the conversion
 * **[breaking]** changed the environment variable `SteamAppPath` to `GseAppPath`, which is used to override the program path detected by the emu
+* **[breaking]** removed the setting `disable_account_avatar` in favor of the new one `enable_account_avatar`, this feature is now disabled by default
 * new option `add_steam_preowned_ids` in `configs.main.ini` which allows adding a lot of Steam builtin and preowned IDs to the DLC list, and the emu's list of installed apps
 * added a workaround for Steam Input, set `disable_steamoverlaygameid_env_var=1` inside `configs.main.ini`, might not work though
 * removed the limit on the amount of characters for local saves

dll/dll/settings.h

@@ -222,7 +222,7 @@ public:
     // bypass to make SetAchievement() always return true, prevent some games from breaking
     bool achievement_bypass = false;
 
-    bool disable_account_avatar = false;
+    bool disable_account_avatar = true;
 
     // setting this env var conflicts with Steam Input
     bool disable_steamoverlaygameid_env_var = false;

dll/settings_parser.cpp

@@ -1223,8 +1223,8 @@ static void parse_simple_features(class Settings *settings_client, class Setting
     settings_client->use_gc_token = ini.GetBoolValue("main::general", "gc_token", settings_client->use_gc_token);
     settings_server->use_gc_token = ini.GetBoolValue("main::general", "gc_token", settings_server->use_gc_token);
 
-    settings_client->disable_account_avatar = ini.GetBoolValue("main::general", "disable_account_avatar", settings_client->disable_account_avatar);
+    settings_client->disable_account_avatar = !ini.GetBoolValue("main::general", "enable_account_avatar", !settings_client->disable_account_avatar);
-    settings_server->disable_account_avatar = ini.GetBoolValue("main::general", "disable_account_avatar", settings_server->disable_account_avatar);
+    settings_server->disable_account_avatar = !ini.GetBoolValue("main::general", "enable_account_avatar", !settings_server->disable_account_avatar);
 
     settings_client->is_beta_branch = ini.GetBoolValue("main::general", "is_beta_branch", settings_client->is_beta_branch);
     settings_server->is_beta_branch = ini.GetBoolValue("main::general", "is_beta_branch", settings_server->is_beta_branch);

post_build/steam_settings.EXAMPLE/configs.main.EXAMPLE.ini

@@ -7,8 +7,8 @@ new_app_ticket=1
 gc_token=1
 # pretend the app is running on a steam deck
 steam_deck=0
-# disable avatar functionality
+# enable avatar functionality
-disable_account_avatar=1
+enable_account_avatar=0
 # prevent Steam_User_Stats::FindLeaderboard() from always succeeding and creating the unknown leaderboard
 # not recommended to disable this
 disable_leaderboards_create_unknown=0

tools/generate_emu_config/generate_emu_config.py

@@ -291,9 +291,6 @@ TOP_OWNER_IDS = list(dict.fromkeys([
 # extra features/options to disable
 EXTRA_FEATURES_DISABLE = {
     'configs.main.ini': {
-        'main::general': {
-            'disable_account_avatar': (1, 'disable avatar functionality'),
-        },
         'main::connectivity': {
             'disable_networking': (1, 'disable all steam networking interface functionality'),
             'disable_source_query': (1, 'do not send server details to the server browser, only works for game servers'),
@@ -308,6 +305,7 @@ EXTRA_FEATURES_CONVENIENT = {
         'main::general': {
             'new_app_ticket': (1, 'generate new app auth ticket'),
             'gc_token': (1, 'generate/embed GC token inside new App Ticket'),
+            'enable_account_avatar': (1, 'enable avatar functionality'),
         },
         'main::connectivity': {
             'disable_lan_only': (1, 'prevent hooking OS networking APIs and allow any external requests'),

tools/migrate_gse/main.py

@@ -188,7 +188,7 @@ def main():
             merge_dict(out_dict_ini, {
                 'configs.main.ini': {
                     'main::general': {
-                        'disable_account_avatar': (1, 'disable avatar functionality'),
+                        'enable_account_avatar': (0, 'enable avatar functionality'),
                     },
                 }
             })